Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CF: don't build swift-corefoundation anymore on Hydra #73501

Closed
wants to merge 1 commit into from
Closed

CF: don't build swift-corefoundation anymore on Hydra #73501

wants to merge 1 commit into from

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Nov 16, 2019

It fails almost every time. Sometimes, after a restart it does build but
not always. To reduce the noise from this failure and all its reverse
dependencies, let's not build it anymore on Hydra.

#72146

Motivation for this change

cc @NixOS/darwin-maintainers @vcunat

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@FRidh
CF: don't build swift-corefoundation anymore on Hydra
f61029e 
It fails almost every time. Sometimes, after a restart it does build but
not always. To reduce the noise from this failure and all its reverse
dependencies, let's not build it anymore on Hydra.

NixOS#72146
@FRidh FRidh added the 6.topic: darwin Running or building packages on Darwin label Nov 16, 2019
@vcunat
Copy link
Member

vcunat commented Nov 16, 2019

Note: on 19.09 it's probably bearable (rarely needs to rebuild), but for staging(-next) work it's a real problem.

@vcunat
Copy link
Member

vcunat commented Nov 16, 2019 •
edited

BUT, I don't think this PR helps as-is. The problem of the breakage is that so many packages depend on this package ATM.

@vcunat
Copy link
Member

vcunat commented Nov 16, 2019

And the ticket with most information on is #66811

@LnL7
Copy link
Member

LnL7 commented Nov 16, 2019

CoreFoundation is part of the stdenv so this is kind of pointless. I'm not sure how to debug it further, almost seems like a compiler bug. The only workaround I can think of at the moment is retrying the build phase similar to my reproduction snippet, but that's pretty horrible 😕.

@vcunat
Copy link
Member

vcunat commented Nov 16, 2019

OK, discussion can continue on that open ticket.

@vcunat vcunat closed this Nov 16, 2019
@veprbl veprbl mentioned this pull request Nov 17, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FRidh @vcunat @LnL7