Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wasabiwallet: 1.1.9 -> 1.1.9.2 #73529

Merged
merged 1 commit into from Nov 17, 2019
Merged

wasabiwallet: 1.1.9 -> 1.1.9.2 #73529

merged 1 commit into from Nov 17, 2019

Conversation

hkjn
Copy link
Contributor

@hkjn hkjn commented Nov 17, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @mmahut

@ofborg ofborg bot requested a review from mmahut November 17, 2019 02:10
prusnak
prusnak approved these changes Nov 17, 2019
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The built binary works

@mmahut
Copy link
Member

mmahut commented Nov 17, 2019

Thank you for updating and reviewing.

@mmahut mmahut merged commit 9b9b349 into NixOS:master Nov 17, 2019
@hkjn hkjn deleted the 20191116-wasabi-1.1.9.2 branch November 17, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@mmahut mmahut Awaiting requested review from mmahut mmahut is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hkjn @mmahut @prusnak