Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retext: fix chardet override #73536

Merged
merged 1 commit into from Nov 17, 2019
Merged

retext: fix chardet override #73536

merged 1 commit into from Nov 17, 2019

Conversation

ahiaao
Copy link
Contributor

@ahiaao ahiaao commented Nov 17, 2019 •
edited

Motivation for this change

Fixes https://hydra.nixos.org/build/106817661 which was broken by #63169 b7923da

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @klntsky

@ahiaao ahiaao mentioned this pull request Nov 17, 2019
Merged
10 tasks
@jonringer
Copy link
Contributor

@GrahamcOfBorg build retext

jonringer
jonringer approved these changes Nov 17, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
does in fact fix build

[6 built, 12 copied (34.9 MiB), 5.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73536
1 package were build:
retext

@jonringer jonringer merged commit d3ac0e9 into NixOS:master Nov 17, 2019
@ahiaao ahiaao deleted the fix/retext-chardet-override branch November 17, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahiaao @jonringer