Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retext: fix chardet override 19.09 backport #73537

Merged
merged 1 commit into from Nov 17, 2019
Merged

retext: fix chardet override 19.09 backport #73537

merged 1 commit into from Nov 17, 2019

Conversation

ahiaao
Copy link
Contributor

@ahiaao ahiaao commented Nov 17, 2019

Motivation for this change

Backports #73536 to fix https://hydra.nixos.org/build/106240459

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @klntsky

@ahiaao ahiaao changed the base branch from master to release-19.09 November 17, 2019 07:05
@ahiaao
Copy link
Contributor Author

ahiaao commented Nov 17, 2019

Sorry. I accidentally forgot to select release-19.09 to merge into.

@ahiaao ahiaao changed the title Fix/retext chardet override backport retext: fix chardet override 19.09 backport Nov 17, 2019
@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@jonringer
Copy link
Contributor

this PR # is a palindrome :)

jonringer
jonringer approved these changes Nov 17, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
does in fact fix build

[5 built, 7 copied (297.6 MiB), 50.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73537
1 package were build:
retext

@jonringer
Copy link
Contributor

@GrahamcOfBorg build retext

@jonringer jonringer merged commit fdb3cd2 into NixOS:release-19.09 Nov 17, 2019
@ahiaao ahiaao deleted the fix/retext-chardet-override-backport branch November 17, 2019 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@adisbladis adisbladis Awaiting requested review from adisbladis

@alyssais alyssais Awaiting requested review from alyssais

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@edolstra edolstra Awaiting requested review from edolstra

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@FRidh FRidh Awaiting requested review from FRidh

@infinisil infinisil Awaiting requested review from infinisil

@joachifm joachifm Awaiting requested review from joachifm

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@nbp nbp Awaiting requested review from nbp

@peti peti Awaiting requested review from peti

@ttuegel ttuegel Awaiting requested review from ttuegel

@WilliButz WilliButz Awaiting requested review from WilliButz

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ahiaao @jonringer