Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xerox6280: init at 1.0-1 #73465

Closed
wants to merge 2 commits into from
Closed

xerox6280: init at 1.0-1 #73465

wants to merge 2 commits into from

Conversation

JoeDupuis
Copy link
Contributor

@JoeDupuis JoeDupuis commented Nov 15, 2019 •
edited

Motivation for this change

Add xerox 6280 (DN/DT/N) printers ppd files.
The xerox 6280 Do not print correctly with the generic ones.

Things done

It's only ppd files. I only tested it on Nixos, but there is no executable.
Should work on all linux distribution.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Should work too, it's only the ppd files, no executable)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

samueldr
samueldr requested changes Nov 15, 2019
View reviewed changes
Copy link
Member

@samueldr samueldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! 👋 Thanks for your first contribution!

Some changes at first glance:

  • A derivation, lost in directories, won't be useful, it will need an attribute name and reference in pkgs/top-level/all-packages.nix.
  • Ideally, if not too much of a burden for you, it would be best that you split the addition of yourself to maintainers/maintainer-list.nix into a separate commit.

In addition to the inline comments.

pkgs/misc/cups/drivers/xerox6280/default.nix Outdated Show resolved Hide resolved
pkgs/misc/cups/drivers/xerox6280/default.nix Outdated Show resolved Hide resolved
@JoeDupuis
Maintainers: add twistedjoe
87a8233
@JoeDupuis
xerox6280: init at 1.0-1
4ca73ab 
Add xerox 6280 (DN/DT/N) printers ppd files.
@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@JoeDupuis JoeDupuis closed this Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr requested changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: printing 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoeDupuis @samueldr @Janik-Haag