Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blugon: init at 1.11.4 #73476

Merged
merged 1 commit into from Nov 17, 2019
Merged

blugon: init at 1.11.4 #73476

merged 1 commit into from Nov 17, 2019

Conversation

jumper149
Copy link
Contributor

Motivation for this change

Adding a new application.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date (there is only metadata)
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

JohnAZoidberg
JohnAZoidberg requested changes Nov 16, 2019
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! :)

Tested and it seems to work.
Is the filter supposed to stay after I kill the program?
Got my natural color back with blugon --setcurrent=6600.0

pkgs/applications/misc/blugon/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/blugon/default.nix Outdated Show resolved Hide resolved
@jumper149
Copy link
Contributor Author

Is the filter supposed to stay after I kill the program?
Got my natural color back with blugon --setcurrent=6600.0

Yes this just the way it's intended to be!

@jumper149
Copy link
Contributor Author

I used git rebase to fixup the previous commit.

JohnAZoidberg
JohnAZoidberg requested changes Nov 17, 2019
View reviewed changes
Copy link
Member

@JohnAZoidberg JohnAZoidberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor things, then it should be okay :)

pkgs/applications/misc/blugon/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/blugon/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/blugon/default.nix Show resolved Hide resolved
pkgs/applications/misc/blugon/default.nix Outdated Show resolved Hide resolved
@ryantm ryantm merged commit 30fa836 into NixOS:master Nov 17, 2019
@ryantm
Copy link
Member

ryantm commented Nov 17, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg Awaiting requested review from JohnAZoidberg

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jumper149 @ryantm @JohnAZoidberg