Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin.CF: workaround intermittent CFRuntime.c failures #73572

Merged
merged 1 commit into from Nov 18, 2019
Merged

darwin.CF: workaround intermittent CFRuntime.c failures #73572

merged 1 commit into from Nov 18, 2019

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Nov 17, 2019

Based on testing this issue seems to only occur with clang_7, so
we should be able to revert this when the default llvm versions are
updated.

Fixes #66811

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @NixOS/darwin-maintainers @vcunat @FRidh

@LnL7
darwin.CF: workaround intermittent CFRuntime.c failures
41ca861 
Based on testing this issue seems to only occur with clang_7, so
we should be able to revert this when the default llvm versions are
updated.

Fixes NixOS#66811
@veprbl
Copy link
Member

veprbl commented Nov 17, 2019

Should this also revert #73501?

@vcunat
Copy link
Member

vcunat commented Nov 18, 2019

That one was never merged.

vcunat
vcunat approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, let's do this hack for now; re-running ninja should be a very low overhead compared to restarting all the jobs on Hydra. Perhaps we can follow-up soon with llvm update.

vcunat added a commit that referenced this pull request Nov 18, 2019
@vcunat
Merge #73572: darwin.CF: hack around build failures
ed9fb90 
... into staging-next.  Fixes #66811, kinda.
@vcunat vcunat merged commit 41ca861 into NixOS:staging-next Nov 18, 2019
@vcunat
Copy link
Member

vcunat commented Nov 18, 2019

Now it succeeded on the first attempt 🤷‍♀️

@FRidh
Copy link
Member

FRidh commented Nov 18, 2019

That's good news!

@LnL7
Copy link
Member Author

LnL7 commented Nov 18, 2019

Yeah. I'm looking into updating the stdenv and bootstrap-tools to llvm_9, but that will probably be a longer term project and won't be something we can pull into 19.09.

@LnL7 LnL7 deleted the darwin-cfruntime-hack branch November 18, 2019 21:50
@vcunat
Copy link
Member

vcunat commented Nov 19, 2019

Right, I planned to use this in 19.09 as soon as the problem is encountered in there again. (There's probably not much sense to apply it "in advance".)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LnL7 @veprbl @vcunat @FRidh