Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] Revert "ncmpc: 0.35 -> 0.36" #73508

Merged
merged 1 commit into from Nov 16, 2019
Merged

[19.09] Revert "ncmpc: 0.35 -> 0.36" #73508

merged 1 commit into from Nov 16, 2019

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Nov 16, 2019

Motivation for this change

ncmpc 0.36 isn't compatible with mpd 0.20 which is the version packaged on
the release-19.09 branch.

See #73000 (comment).

This reverts commit 245f5ec.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @fpletz @phi-gamma

@pacien
Revert "ncmpc: 0.35 -> 0.36"
7d2b904 
ncmpc 0.36 isn't compatible with mpd 0.20 which is the version packaged on
the release-19.09 branch.

See NixOS#73000 (comment).

This reverts commit 245f5ec.
@ofborg ofborg bot requested a review from fpletz November 16, 2019 16:00
@fpletz
Copy link
Member

fpletz commented Nov 16, 2019

Thanks, forgot to push this.

@fpletz fpletz merged commit 7227ca7 into NixOS:release-19.09 Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pacien @fpletz