Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vym: 2.6.11 -> 2.7.0 #73483

Merged
merged 4 commits into from Dec 12, 2019
Merged

vym: 2.6.11 -> 2.7.0 #73483

merged 4 commits into from Dec 12, 2019

Conversation

ghost
Copy link

@ghost ghost commented Nov 16, 2019

Motivation for this change

Version bump.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @AndersonTorres

@ofborg ofborg bot requested a review from AndersonTorres November 16, 2019 05:37
@dtzWill
Copy link
Member

dtzWill commented Nov 16, 2019

Added some fixups I've apparently been sitting on since June? Anyway the first installs the vym manpage, the second fixes some strange installation into $out/vym as well as patches around hardcoded references to /usr.

As for the PR before those commits: please modify the commit message to adhere to the guidelines... the PR title is the right text :). I didn't make this change to avoid force-pushing to your branch w/o discussion at least :).

@ghost
Copy link
Author

ghost commented Nov 16, 2019

As for the PR before those commits: please modify the commit message to adhere to the guidelines...

Sorry about that, I submitted this PR quickly through the website and I'm not sure how to change a commit message via the web interface.

@dtzWill
Copy link
Member

dtzWill commented Nov 16, 2019

Sorry about that, I submitted this PR quickly through the website and I'm not sure how to change a commit message via the web interface.

I don't either, but since I'm already setup to push to the branch it's easy enough to do locally :).

@dtzWill
Copy link
Member

dtzWill commented Nov 16, 2019

Let's give @AndersonTorres a chance to take a look, but otherwise LGTM. Thanks!

@dtzWill dtzWill mentioned this pull request Nov 17, 2019
Closed
10 tasks
@nek0
Copy link
Contributor

nek0 commented Nov 17, 2019 •
edited

Please add also wrapQtAppsHook in nativeBuildInputs or the executable probably won't run properly. The underlying issue is described in this manual section.
Also bear in mind that version 2.7.1 of vym is not intended to be stable at the moment.

@dtzWill
Copy link
Member

dtzWill commented Nov 17, 2019

Please add also wrapQtAppsHook in nativeBuildInputs or the executable probably won't run properly. The underlying issue is described in this manual section.

No need for worrying about wrapping ourselves, that's why this uses mkDerivation from the qt set.

From the manual you linked:

. If you cannot use mkDerivation or mkDerivationWith above, include wrapQtAppsHook

On the other hand,

Also bear in mind that version 2.7.1 of vym is not intended to be stable at the moment.

That's good to know, and we should probably use the version upstream marks ready and stable :).

If you don't mind, can you link or point me to where they say 2.7.1 isn't ready? Sorry for missing it!

On a whim checked repology.org stats and looks like I'm not the only one who missed the memo:
https://repology.org/projects/?search=vym
(2.7.1 is packaged by a number of distributions, most popular version depending on how you count it). So a PSA might be in order depending what we end up using :).

@nek0
Copy link
Contributor

nek0 commented Nov 17, 2019

Please add also wrapQtAppsHook in nativeBuildInputs or the executable probably won't run properly. The underlying issue is described in this manual section.

No need for worrying about wrapping ourselves, that's why this uses mkDerivation from the qt set.

From the manual you linked:

. If you cannot use mkDerivation or mkDerivationWith above, include wrapQtAppsHook

Ok. I'm sorry, if I caused any hassle.

On the other hand,

Also bear in mind that version 2.7.1 of vym is not intended to be stable at the moment.

That's good to know, and we should probably use the version upstream marks ready and stable :).

If you don't mind, can you link or point me to where they say 2.7.1 isn't ready? Sorry for missing it!

On a whim checked repology.org stats and looks like I'm not the only one who missed the memo:
https://repology.org/projects/?search=vym
(2.7.1 is packaged by a number of distributions, most popular version depending on how you count it). So a PSA might be in order depending what we end up using :).

Concerning that I only have a screenshot of the release notes window, which pops up after starting vym the first time:

vym_unstable

@dtzWill
Copy link
Member

dtzWill commented Nov 17, 2019 via email

@ghost
Copy link
Author

ghost commented Nov 18, 2019 •
edited by ghost

I should add that when choosing 2.7.1 I just picked the latest version from sourceforge. There was no indication that it was a development version (and there is a folder for development releases that this was not in). I noticed that 2.7.1 only comes as a tarball without releases for Windows, so I assumed it was a minor version that contained a Linux-specific bug fix.

Also in the "About" window, the version is listed as 2.7.500 - 2019-05-08

I'm fine switching to whatever version we can agree is the latest stable.

@nek0
Copy link
Contributor

nek0 commented Nov 22, 2019

I would also suggest using version 2.7.0 for packaging.

Change version to 2.7.0
91bc920 
There was some concern that the release tarball 2.7.1 actually contains an in-development snapshot rather than a full release. The consensus seems to be that 2.7.0 should be used instead.
@c0bw3b c0bw3b changed the title vym: 2.6.11 -> 2.7.1 vym: 2.6.11 -> 2.7.0 Dec 12, 2019
c0bw3b
c0bw3b approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nix-review pr 73483 1

1 package were build:
  • vym
$ ./results/vym/bin/vym --version
VYM - View Your Mind (c) 2004-2019 Uwe Drechsel 
   Version: 2.7.0
Build date: 2019-04-14
  Codename: Production release

@c0bw3b c0bw3b merged commit 286ef71 into NixOS:master Dec 12, 2019
@ghost ghost deleted the patch-1 branch December 20, 2019 05:02
@ghost ghost mentioned this pull request Jan 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @nek0 @c0bw3b