Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texstudio: fix QT5 #73484

Merged
merged 1 commit into from Nov 16, 2019
Merged

texstudio: fix QT5 #73484

merged 1 commit into from Nov 16, 2019

Conversation

nek0
Copy link
Contributor

@nek0 nek0 commented Nov 16, 2019

Motivation for this change

texstudio refused to start due to following error:

qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""

Fix applied as described in NixOS wiki.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Chaddai

@ofborg ofborg bot requested a review from Chaddai November 16, 2019 06:29
bjornfor
bjornfor requested changes Nov 16, 2019
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please prefix commit subject with package name.

@nek0
Copy link
Contributor Author

nek0 commented Nov 16, 2019

Like this?

@bjornfor bjornfor merged commit 8c42dba into NixOS:master Nov 16, 2019
@bjornfor
Copy link
Contributor

Like this?

Yes. Thanks!

@bb010g
Copy link
Member

bb010g commented Jan 5, 2020

Could this be pulled into release-19.09?

@bb010g bb010g mentioned this pull request Jan 5, 2020
Closed
@bjornfor
Copy link
Contributor

bjornfor commented Jan 5, 2020

Backported with b926503 and parent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@Chaddai Chaddai Awaiting requested review from Chaddai

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nek0 @bjornfor @bb010g