Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-fuzz: 0.5.3 -> 0.5.4 #73576

Merged
merged 1 commit into from Nov 18, 2019
Merged

cargo-fuzz: 0.5.3 -> 0.5.4 #73576

merged 1 commit into from Nov 18, 2019

Conversation

killercup
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Ekleog

@ofborg ofborg bot requested a review from Ekleog November 17, 2019 18:38
jonringer
jonringer approved these changes Nov 17, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM
executable shows usage

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73576
1 package were build:
cargo-fuzz

thank you for making the expression look a lot better

@jonringer
Copy link
Contributor

@GrahamcOfBorg build cargo-fuzz

killercup
killercup commented Nov 17, 2019
View reviewed changes
pkgs/development/tools/rust/cargo-fuzz/default.nix Outdated
cp ${cargo-lock} $out/Cargo.lock
'';
src = fetchFromGitHub {
owner = "rust-fuzz";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry, just noticed the stray tabs here. That's what I get for not having my vim config on the other laptop, I guess!

Let me know if/how to fix this without triggering a full CI run.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A full CI run only happens when someone asks ofBorg to do it (or you have permissions). So don't worry about fixing it: hydra will only check if your stuff evaluates (and some other stuff)

spacekookie
spacekookie reviewed Nov 17, 2019
View reviewed changes
Copy link
Member

@spacekookie spacekookie left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you pointed out the diff is a bit big because of the tabs, but otherwise it looks good to me! 👍

(maybe nobody merge this before the tabs have been dealt with 😅)

@killercup
Copy link
Member Author

killercup commented Nov 17, 2019 via email

@jonringer
Copy link
Contributor

@GrahamcOfBorg build cargo-fuzz

@jonringer jonringer merged commit e89c1c7 into NixOS:master Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spacekookie spacekookie spacekookie left review comments

@jonringer jonringer jonringer approved these changes

@Ekleog Ekleog Awaiting requested review from Ekleog

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@killercup @jonringer @spacekookie