Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dotnet-sdk: 2.2.401 -> 3.0.100 #73551

Closed
wants to merge 1 commit into from
Closed

dotnet-sdk: 2.2.401 -> 3.0.100 #73551

wants to merge 1 commit into from

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Nov 17, 2019

Motivation for this change

.NET Core 3.0 was released on 2019-09-23.

Things done

I was able to compile, run and test a .NET Core 3.0 application.

For one application I had a problem that dotnet searched for a non-existing binary (obj/Debug/netcoreapp3.0/project, without a .dll ending). But I don’t know if this is related to .NET Core or a fault of the application I tested.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @kuznero

@ofborg ofborg bot requested a review from kuznero November 17, 2019 12:22
@prusnak
Copy link
Member

prusnak commented Nov 17, 2019

Duplicate of #69392

@Flakebi
Copy link
Member Author

Flakebi commented Nov 17, 2019

Ups, closing then. Thanks!

@Flakebi Flakebi closed this Nov 17, 2019
@Flakebi Flakebi deleted the dotnet branch November 17, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuznero kuznero Awaiting requested review from kuznero

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Flakebi @prusnak