Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openarena: fix service's binary name #73553

Merged
merged 1 commit into from Nov 24, 2019
Merged

openarena: fix service's binary name #73553

merged 1 commit into from Nov 24, 2019

Conversation

tomfitzhenry
Copy link
Contributor

The binary name was recently changed from openarena-server to oa_ded in
#71122 .

That change broke the openarena module and consequently the openarena
test too. This commit fixes both.

As an alternative, we considered reverting the name change in
#72824 but we decided oa_ded was
a better name for the binary (it's the name upstream use).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor

@GrahamcOfBorg test openarena

@jonringer
Copy link
Contributor

confirmed the test times out on master

jonringer
jonringer reviewed Nov 17, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review -> 0 rebuilds
fixes test

do you mind changing the commit name to:

nixos/openarena: fix service's binary name

otherwise LGTM

@tomfitzhenry
nixos/openarena: fix service's binary name
95d8988 
The binary name was recently changed from openarena-server to oa_ded in
#71122 .

That change broke the openarena module and consequently the openarena
test too. This commit fixes both.

As an alternative, we considered reverting the name change in
#72824 but we decided oa_ded was
a better name for the binary (it's the name upstream use).
@tomfitzhenry
Copy link
Contributor Author

do you mind changing the commit name

Done.

@jonringer
Copy link
Contributor

@GrahamcOfBorg test openarena

Lassulus
Lassulus approved these changes Nov 24, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested with nix-review, tests completes successfully

@Lassulus Lassulus merged commit 58498ae into NixOS:master Nov 24, 2019
@veprbl veprbl mentioned this pull request Feb 9, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomfitzhenry @jonringer @Lassulus