Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5: 5.12.5 -> 5.12.6 #73562

Merged
merged 1 commit into from Nov 24, 2019
Merged

qt5: 5.12.5 -> 5.12.6 #73562

merged 1 commit into from Nov 24, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Nov 17, 2019

Motivation for this change

https://www.qt.io/blog/qt-5.12.6-released

Intended to be fixes only (safe), from language in the post.

Still building and testing, particularly the qtweb* beasts :).

So far so good...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

(folks recently committing to these files, anyway..)

cc @Ericson2314
cc @vcunat
cc @adisbladis
cc @ttuegel

@dtzWill
Copy link
Member Author

dtzWill commented Nov 17, 2019

Using this presently on my machines, FWIW! :)

Ericson2314
Ericson2314 approved these changes Nov 18, 2019
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I've only been fixing set -u errors with Qt lately, nothing creative, so ignore me :)

@dtzWill
Copy link
Member Author

dtzWill commented Nov 18, 2019

Oh, I've only been fixing set -u errors with Qt lately, nothing creative, so ignore me :)

😻 for the set -u improvements! And oops I suppose i could have read the commit messages ;innocent:.

@ghost
Copy link

ghost commented Nov 18, 2019

This should probably make at least one patch unnecessary.

@FRidh FRidh added this to Needs review in Staging Nov 19, 2019
@FRidh FRidh merged commit cc4ff09 into NixOS:staging Nov 24, 2019
Staging automation moved this from Needs review to Done Nov 24, 2019
lavoiesl added a commit to Shopify/nixpkgs that referenced this pull request Dec 3, 2019
@lavoiesl
Update qtbase mac patches for 5.12.6
321987b 
qtbase was updated to 5.12.6 in NixOS#73562,
but the patch for macOS wasn't regenerated, causing the build to fail.
@lavoiesl lavoiesl mentioned this pull request Dec 3, 2019
Merged
10 tasks
veprbl pushed a commit that referenced this pull request Dec 3, 2019
@lavoiesl @veprbl
qt5.qtbase: fix darwin patches for 5.12.6 (#74911)
f27b686 
qtbase was updated to 5.12.6 in #73562,
but the patch for macOS wasn't updated, causing the build to fail.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @Ericson2314 @FRidh