Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc7: 7.4.0 -> 7.5.0 #73561

Closed
wants to merge 1 commit into from
Closed

gcc7: 7.4.0 -> 7.5.0 #73561

wants to merge 1 commit into from

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Nov 17, 2019

Motivation for this change

https://www.mail-archive.com/gcc@gcc.gnu.org/msg89640.html

Sending to master optimistically, since this is no longer our default
compiler.

Let's see ;).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Nov 19, 2019

Beep boop :).

@dtzWill
Copy link
Member Author

dtzWill commented Dec 6, 2019

cc @NixOS/darwin-maintainers :

  • Darwin is where all the rebuilds are, is there a preferred way to handle this? Should it go to staging?
  • Should be safe, but would be good to ensure at least builds on Darwin before merging :).

@LnL7
Copy link
Member

LnL7 commented Dec 6, 2019

There's a conditional we should get rid of. However, it's mostly some python packages that rebuild so hydra should get through those pretty quickly.

@dtzWill
Copy link
Member Author

dtzWill commented Dec 16, 2019

Looks like @vcunat pushed the bump today (independently): 56622fa , if there's still cleanup needed (conditional to remove?) can you make a PR for that @LnL7 (just to show what you mean if nothing else :)).

Closing this, though, since it's already in master :).

@dtzWill dtzWill closed this Dec 16, 2019
@LnL7
Copy link
Member

LnL7 commented Dec 16, 2019

@dtzWill Already looked into it 😄 #75094.

@dtzWill
Copy link
Member Author

dtzWill commented Dec 16, 2019

Great! ❤️

@vcunat
Copy link
Member

vcunat commented Dec 16, 2019

Hmm, I tried searching quickly but didn't find this PR :-/

@dtzWill
Copy link
Member Author

dtzWill commented Dec 16, 2019 via email

@vcunat
Copy link
Member

vcunat commented Dec 17, 2019

Maybe some general-purpose search engine will do better than GitHub itself (Google.com or others).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @LnL7 @vcunat