hyperspace: init at 1.1.4 #73564

dtzWill · 2019-11-17T14:35:15Z

Motivation for this change

Mastodon client :).
(electron-based)

FWIW, the license is new to us and not widely used.

Added it to the list, but am unsure how it should be handled.
Hopefully it's alright to include software under this license,
but I mention it because I would appreciate a second opinion O:).

Fixes #57357.

Things done

lib/licenses.nix

pkgs/applications/misc/hyperspace/default.nix

stale · 2020-06-13T15:46:52Z

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

Search for maintainers and people that previously touched the related code and @ mention them in a comment.
Ask on the NixOS Discourse.
Ask on the #nixos channel on irc.freenode.net.

matthiasbeyer · 2020-10-16T20:03:20Z

The package works, would be nice to have it in nixpkgs...

pkgs/applications/misc/hyperspace/default.nix

pkgs/top-level/all-packages.nix

stale · 2021-06-03T19:34:53Z

I marked this as stale due to inactivity. → More info

dtzWill · 2021-11-18T23:25:35Z

Updates/notes for anyone reading this in the future:

NPL is a bit of a mess, it seems? Not free (I think we discussed this somewhere previously too), according to hyperspace discussion on changing its license (not linking to avoiding bombing them with mention, LMK if curious/can't find), bumped to v4 from the v1 included with this PR originally. Authoritative URL for this version is tricky, it seems NPL author wants folks using v7+ and deprecated the v4 repository ... anyway this seems correct for hyperspace, which explicitly uses "NPLv4".
As I recall, the runtime deps are needed because they're looked for but not linked against explicitly, now that we have to pull in mesa for libgbm I'm unsure if that makes sense re:libGL. Leaving as I think libGL is preferred unless mesa itself is explicitly needed.
There's an appimage alternative they provide which might be preferred (if simpler to package), I don't know if there's a reason I went for the .deb. Seems less opaque :). In theory we could maybe bundle this ourselves but I haven't explored this, as the tooling isn't very Nix-compat (node). Staying the course for now.

Addressed review feedback, thank you! Sorry for delay! :)

Tested the result and seems to work as expected so far.

The icon is... X11 logo? Which suggests something strange happening but I don't think is critical.

--

Well anyway, here's the latest hyperspace :).

SuperSandro2000 · 2021-11-20T18:52:36Z

pkgs/applications/misc/hyperspace/default.nix

+  version = "1.1.4";
+
+  src = fetchurl {
+    url = "https://github.com/hyperspacedev/${pname}/releases/download/v${version}/${pname}_${version}_amd64.deb";


Suggested change

url = "https://github.com/hyperspacedev/${pname}/releases/download/v${version}/${pname}_${version}_amd64.deb";

url = "https://github.com/hyperspacedev/hyperspace/releases/download/v${version}/hyperspace_${version}_amd64.deb";

easy to visit links are important if you want to research with one click if this can be build from source.

SuperSandro2000 · 2021-11-20T18:53:24Z

pkgs/applications/misc/hyperspace/default.nix

+  dontStrip = true;
+  dontPatchELF = true;


Those break the binary?

SuperSandro2000 · 2021-11-20T18:53:36Z

pkgs/applications/misc/hyperspace/default.nix

+    description = "A beautiful, fluffy client for the fediverse";
+    homepage = "https://hyperspace.marquiskurt.net";
+    license = licenses.npl4;
+    maintainers = with maintainers; [ dtzWill ];


Presumable platforms.linux, right?

onny · 2022-09-07T06:32:45Z

Please rebase

Mic92 · 2022-12-18T08:33:42Z

Closing because of lack of activity from the author. Please re-open if you plan to work on this.

dtzWill requested a review from alyssais as a code owner November 17, 2019 14:35

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Nov 17, 2019

vyp reviewed Nov 17, 2019

View reviewed changes

lib/licenses.nix Outdated Show resolved Hide resolved

jonringer reviewed Nov 17, 2019

View reviewed changes

pkgs/applications/misc/hyperspace/default.nix Outdated Show resolved Hide resolved

dtzWill force-pushed the feature/hyperspace branch from e5b2cd5 to cce9337 Compare November 17, 2019 22:11

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 13, 2020

ryantm added 2.status: merge conflict and removed 2.status: merge conflict labels Oct 3, 2020

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 16, 2020

SuperSandro2000 requested changes Nov 27, 2020

View reviewed changes

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021

stale bot removed 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md labels Nov 18, 2021

dtzWill force-pushed the feature/hyperspace branch from cce9337 to bcc67dc Compare November 18, 2021 22:57

ofborg bot removed the 2.status: merge conflict label Nov 18, 2021

licenses: add npl4, "Non-Violent Public License v4"

22b2735

dtzWill force-pushed the feature/hyperspace branch from ef6472f to eddb645 Compare November 18, 2021 23:06

dtzWill changed the title ~~hyperspace: init at 1.0.3~~ hyperspace: init at 1.1.4 Nov 18, 2021

hyperspace: init at 1.1.4

b155ba0

dtzWill force-pushed the feature/hyperspace branch from eddb645 to b155ba0 Compare November 18, 2021 23:09

ofborg bot added the 10.rebuild-linux: 1 label Nov 18, 2021

SuperSandro2000 reviewed Nov 20, 2021

View reviewed changes

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 19, 2022

onny marked this pull request as draft September 7, 2022 06:32

Mic92 closed this Dec 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hyperspace: init at 1.1.4 #73564

hyperspace: init at 1.1.4 #73564

dtzWill commented Nov 17, 2019 •

edited

stale bot commented Jun 13, 2020

matthiasbeyer commented Oct 16, 2020 •

edited

stale bot commented Jun 3, 2021

dtzWill commented Nov 18, 2021

SuperSandro2000 Nov 20, 2021

SuperSandro2000 Nov 20, 2021

SuperSandro2000 Nov 20, 2021

onny commented Sep 7, 2022

Mic92 commented Dec 18, 2022

	url = "https://github.com/hyperspacedev/${pname}/releases/download/v${version}/${pname}_${version}_amd64.deb";
	url = "https://github.com/hyperspacedev/hyperspace/releases/download/v${version}/hyperspace_${version}_amd64.deb";

hyperspace: init at 1.1.4 #73564

hyperspace: init at 1.1.4 #73564

Conversation

dtzWill commented Nov 17, 2019 • edited

Motivation for this change

Things done

stale bot commented Jun 13, 2020

matthiasbeyer commented Oct 16, 2020 • edited

stale bot commented Jun 3, 2021

dtzWill commented Nov 18, 2021

SuperSandro2000 Nov 20, 2021

Choose a reason for hiding this comment

SuperSandro2000 Nov 20, 2021

Choose a reason for hiding this comment

SuperSandro2000 Nov 20, 2021

Choose a reason for hiding this comment

onny commented Sep 7, 2022

Mic92 commented Dec 18, 2022

dtzWill commented Nov 17, 2019 •

edited

matthiasbeyer commented Oct 16, 2020 •

edited