Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/adb: don't make android tools the system-wide mke2fs, lowPrio #73566

Merged
merged 1 commit into from Nov 20, 2019
Merged

nixos/adb: don't make android tools the system-wide mke2fs, lowPrio #73566

merged 1 commit into from Nov 20, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Nov 17, 2019

Motivation for this change

Noticed there was a conflict (non-fatal?) in logs after enabling the adb
module, and wanted to be sure the system-wide binaries for mke2fs and
such came from where it usually does :).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Lassulus
Lassulus approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@Lassulus Lassulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lassulus Lassulus merged commit 6ee7b4d into NixOS:master Nov 20, 2019
@wamserma
Copy link
Member

@Lassulus please also put this onto 19.09

@Lassulus
Copy link
Member

backported in dae3575

@wamserma
Copy link
Member

@Lassulus Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @wamserma @Lassulus