Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mtr: patch for "Error decoding localhost address" #73475

Merged
merged 1 commit into from Nov 15, 2019
Merged

mtr: patch for "Error decoding localhost address" #73475

merged 1 commit into from Nov 15, 2019

Conversation

rwanyoike
Copy link
Contributor

Motivation for this change

Fix mtr Error decoding localhost address on macOS. Expected to be included in next release (0.94).

PR upstream: traviscross/mtr#315
Issue: traviscross/mtr#313

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot requested review from globin and 7c6f434c November 15, 2019 22:28
@globin globin merged commit 8c1a5a3 into NixOS:master Nov 15, 2019
@rwanyoike rwanyoike deleted the patch-1 branch November 15, 2019 22:52
@rwanyoike rwanyoike mentioned this pull request Nov 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rwanyoike @globin @Janik-Haag