Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] steam: use 32bit version of libva #73512

Merged
merged 1 commit into from Nov 19, 2019
Merged

[19.09] steam: use 32bit version of libva #73512

merged 1 commit into from Nov 19, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 16, 2019 •
edited

Motivation for this change

backport of #73481

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
steam: use 32bit version of libva
f77c439 
(cherry picked from commit 87c674d)
@jonringer jonringer changed the title steam: use 32bit version of libva [19.09] steam: use 32bit version of libva Nov 16, 2019
@jonringer
Copy link
Contributor Author

not really able to verify that the 19.09 package is broken, I think the FHSenv is stateful, and don't know how to clear it completely from my computer

@aanderse
Copy link
Member

Not sure what to say @jonringer... Sorry for merging the previous PR I guess. I tested the previous PR and it fixed my broken steam. Kids were happy. I thought we had a winner...

Mildly curious what the issue is.

@jonringer
Copy link
Contributor Author

I think it was another update. and they verified it was a 32bit version

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/steam-cannot-update/4848/2

@jonringer
Copy link
Contributor Author

got confirmation that it's broken, merging :)

@jonringer jonringer merged commit 40fcdac into NixOS:release-19.09 Nov 19, 2019
@jonringer jonringer deleted the fix-steam-release branch November 19, 2019 04:22
@andir
Copy link
Member

andir commented Jan 20, 2020

I have a case where this seems to have broken a game. "DOTA Underlords" seems to expect a 64bit version of libva.so but now with this commit merged it fails to start. I guess if we just add the other lib it clashes? What are our options? Is there some way to have 32bit only LD_LIBRARY_PATH that contains those libs needed for 32bit systems?

@jonringer
Copy link
Contributor Author

That's interesting, as steam won't launch if this is missing. It might be possible to have both present. But I'm not sure

@andir
Copy link
Member

andir commented Jan 21, 2020

Steam did launch after reverting this. I am not entirely sure what is going on :/

@megfault
Copy link

I had that issue with Dota Underlords, reverted this commit and could finally launch the game. Steam is working fine.

@jonringer
Copy link
Contributor Author

It's a FTP game, I'll try myself

This was referenced Jan 22, 2020
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: steam 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jonringer @aanderse @nixos-discourse @andir @megfault