Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mitmproxy: disable example tests #73535

Merged
merged 1 commit into from Nov 17, 2019
Merged

mitmproxy: disable example tests #73535

merged 1 commit into from Nov 17, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Nov 17, 2019 •
edited

Motivation for this change

closes #73506

using the interpreter, it's able to load the example fine, not sure why pytest isn't able to load it. Just decided to deselect the example tests, most of the unit tests run and pass though

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[1 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/73535
1 package were build:
mitmproxy

@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 17, 2019
@jonringer
mitmproxy: disable example tests
38bc374 
pytest5 isn't able to load examples.complex.xss_scanner
even though a normal interpreter session is able to load
it fine.
@ofborg ofborg bot requested review from kamilchm and fpletz November 17, 2019 06:30
@jonringer jonringer merged commit 86d6a63 into NixOS:master Nov 17, 2019
@jonringer jonringer deleted the fix-mitmproxy branch November 17, 2019 08:14
@jonringer
Copy link
Contributor Author

release version seems to build fine

@jonringer jonringer removed the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@kamilchm kamilchm Awaiting requested review from kamilchm

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mitmproxy broken
2 participants
@jonringer @marsam