Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cassandra-driver: 3.18.0 -> 3.19.0 #70144

Merged
merged 1 commit into from Oct 11, 2019
Merged

pythonPackages.cassandra-driver: 3.18.0 -> 3.19.0 #70144

merged 1 commit into from Oct 11, 2019

Conversation

jonringer
Copy link
Contributor

Motivation for this change

while reviewing #69775 I noticed it could be cleaned up and tests should be enabled.

closes #69775

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer jonringer requested a review from FRidh as a code owner October 1, 2019 00:51
@mmahut
Copy link
Member

mmahut commented Oct 10, 2019

@GrahamcOfBorg build pythonPackages.cassandra-driver python3Packages.cassandra-driver

@jonringer
Copy link
Contributor Author 

https://github.com/NixOS/nixpkgs/pull/70144
2 package were build:
python27Packages.cassandra-driver python37Packages.cassandra-driver

@jonringer jonringer merged commit 18faa09 into NixOS:master Oct 11, 2019
@jonringer jonringer deleted the bump-cassandra-driver branch October 11, 2019 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @mmahut