Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svgbob: fix build #70159

Merged
merged 1 commit into from Oct 1, 2019
Merged

svgbob: fix build #70159

merged 1 commit into from Oct 1, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Oct 1, 2019 •
edited by jonringer

Motivation for this change

See https://hydra.nixos.org/build/102480738

Bumping to latest version (which is 0.4.2 according to Cargo.lock) fixes
the build error. As no dependency changes happened, cargoSha256 doesn't
need to be updated.

ZHF #68361

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27
svgbob: fix build
af5d70d 
See https://hydra.nixos.org/build/102480738

Bumping to latest version (which is 0.4.2 according to Cargo.lock) fixes
the build error. As no dependency changes happened, cargoSha256 doesn't
need to be updated.

ZHF NixOS#68361
@Ma27 Ma27 requested a review from marsam October 1, 2019 07:50
@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 1, 2019
marsam
marsam approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@marsam marsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

jonringer
jonringer approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nix-review passes on NixOS
diff LGTM (no releases tagged on GitHub :( )
executable works

[4 built, 4 copied (516.3 MiB), 186.1 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70159
1 package were build:
svgbob

[nix-shell:~/.cache/nix-review/pr-70159]$ nix path-info -Sh ./results/svgbob
/nix/store/rpw4859ncxi5933aqkgjhrqd6wm1lxqq-svgbob-0.4.2          28.3M

@jonringer jonringer merged commit b5204d9 into NixOS:master Oct 1, 2019
@jonringer
Copy link
Contributor

I'm not really sure of the proper process to do a backport :( @Ma27

@Ma27 Ma27 deleted the bump-svgbob branch October 1, 2019 17:14
@Ma27
Copy link
Member Author

Ma27 commented Oct 1, 2019

Backported as 2fc4fab.
I usually do git cherry-pick -x <commit-id> and push this to release-19.09 after testing :)

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam marsam approved these changes

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @jonringer @marsam