Worklet: Reject addModule() with script's error to rethrow if available #19462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Oct 2, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1258785
branch
2 times, most recently
from
ad0b751
to
c82e2f3
Compare
This CL makes Worklet#addModule() fail with a more specific error object compared to before. Before this change, Worklet::addModule() was rejected with AbortError regardless of an actual error reason, and that made it difficult for developers to debug worklets. This behavior was defined in the Worklets spec, but it was changed recently (see the links below). After this change, Worklet::addModule() is rejected with script's error to rethrow when it is available as the new spec defines. Spec changes: - w3c/css-houdini-drafts#958 - w3c/css-houdini-drafts#967 Chromestatus: - https://www.chromestatus.com/feature/5116796497559552 Bug: 782066 Change-Id: Iabd30eff28ed1bffed9219898649a89b8abebbb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1258785 Reviewed-by: Kouhei Ueno <kouhei@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#703606}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1258785
branch
from
c82e2f3
to
11b16a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL makes Worklet#addModule() fail with a more specific error object
compared to before.
Before this change, Worklet::addModule() was rejected with AbortError regardless
of an actual error reason, and that made it difficult for developers to debug
worklets. This behavior was defined in the Worklets spec, but it was changed
recently (see the links below).
After this change, Worklet::addModule() is rejected with script's error to
rethrow when it is available as the new spec defines.
Spec changes:
Chromestatus:
Bug: 782066
Change-Id: Iabd30eff28ed1bffed9219898649a89b8abebbb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1258785
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703606}