Kind of looks unmaintained without any new commits in 3 years. Relevant is https://discourse.nixos.org/t/we-need-more-defined-guidelines-for-package-inclusion/3592

Still want this in nixpkgs?

Maybe you're right. If nobody else is interested in adding this software, I'll close this (and still continue to use it locally).

I pushed an update to the packaging of this to be more standard. Can you test this updated version to make sure it works for you? If it does we can merge this.

What's the distinction here with being called zfsnap2 and zfsnap?

Good point, there shouldn't be a reason to make it be zfsnap2, I changed it to just zfsnap

@infinisil last thing, you forgot to change the commit message.

Thanks. Okay so let's wait for @woffs to report whether the current version works for them.

What's the distinction here with being called zfsnap2 and zfsnap?

zfsnap2 was a rewrite of zfsnap1 and has different cmdline options. See https://github.com/zfsnap/zfsnap/blob/master/README.md

Debian has zfsnap version 1.11 https://packages.debian.org/search?keywords=zfsnap
and I wanted to avoid confusion with this.

I pushed an update to the packaging of this to be more standard. Can you test this updated version to make sure it works for you? If it does we can merge this.

Thanks a lot for your work, I'll take this as new template. Taking zfs from PATH is reasonable, and I did not know installShellFiles yet.

Tests look good! 👍

I'll force-push again to remove the busybox whitespace-removal in all-packages.nix, which, although good to do, does not belong to this PR.

Thanks for reviewing and merging!