Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby: 2.4.7 -> 2.4.9, 2.5.6 -> 2.5.7, 2.6.4 -> 2.6.5 #70232

Merged
merged 4 commits into from
Oct 2, 2019
Merged

ruby: 2.4.7 -> 2.4.9, 2.5.6 -> 2.5.7, 2.6.4 -> 2.6.5 #70232

merged 4 commits into from
Oct 2, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 2, 2019

Motivation for this change

CVE-2019-16255: A code injection vulnerability of Shell#[] and Shell#test
CVE-2019-16254: HTTP response splitting in WEBrick (Additional fix)
CVE-2019-15845: A NUL injection vulnerability of File.fnmatch and File.fnmatch?
CVE-2019-16201: Regular Expression Denial of Service vulnerability of WEBrick’s Digest access authentication

note: I haven't included 2.4.8, because the released tarball doesn’t install under non-root user https://bugs.ruby-lang.org/issues/16197

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

marsam added 3 commits October 2, 2019 00:00
d3983ca removed ruby_2_3 from nixpkgs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@marsam marsam changed the title ruby: 2.5.6 -> 2.5.7, 2.6.4 -> 2.6.5 ruby: 2.4.7 -> 2.4.9, 2.5.6 -> 2.5.7, 2.6.4 -> 2.6.5 Oct 2, 2019
@alyssais alyssais added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Oct 2, 2019
@alyssais alyssais merged commit 5ed9d8b into NixOS:master Oct 2, 2019
@marsam marsam deleted the update-ruby branch October 2, 2019 11:40
@alyssais
Copy link
Member

alyssais commented Oct 2, 2019 via email

@TredwellGit TredwellGit added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: ruby 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants