Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 2ed7dfe245c7
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8d7f2c7f3ed3
Choose a head ref
  • 4 commits
  • 4 files changed
  • 4 contributors

Commits on Oct 1, 2019

  1. quassel: Fix use of mkDerivation

    The `with stdenv;` would override the `mkDerivation` to be the regular
    one, instead of the libsForQt5 one.
    
    This simply removes the dangerous use of the all-encompassing `with`,
    and prefers using a more precise inherit for `lib`.
    
    See #65399
    
    Co-authored-by: worldofpeace <worldofpeace@protonmail.ch>
    (cherry picked from commit c52b5b8)
    samueldr and worldofpeace committed Oct 1, 2019

    Verified

    This commit was signed with the committer’s verified signature. The key has been revoked.
    joachifm Joachim F.
    Copy the full SHA
    0fc13aa View commit details
  2. blueman: no optional networkmanager

    blueman declares NetworkManager gi bindings
    as a required runtime dependency [0]
    
    Fixes #69555
    
    [0]: https://github.com/blueman-project/blueman/blob/531da47b06de3617492cc5ae5530ca8b3f2e12a4/Dependencies.md
    
    (cherry picked from commit fcb84c5)
    worldofpeace committed Oct 1, 2019

    Verified

    This commit was signed with the committer’s verified signature. The key has been revoked.
    joachifm Joachim F.
    Copy the full SHA
    aaa1739 View commit details
  3. epson-escpr2: 1.0.29 -> 1.1.1

    The build was failing because the source rpm does not exist
    on epsons servers anymore.
    
    Thus bumping it to an existing version
    https://hydra.nixos.org/build/101990975/nixlog/5
    
    (cherry picked from commit e338105)
    d-goldin authored and worldofpeace committed Oct 1, 2019

    Partially verified

    This commit is signed with the committer’s verified signature. The key has been revoked.
    joachifm’s contribution has been verified via GPG key.
    We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
    Copy the full SHA
    8ef6192 View commit details
  4. pythonPackages.premailer: fix build

    (cherry picked from commit 1728793)
    Jonathan Ringer authored and Ma27 committed Oct 1, 2019

    Verified

    This commit was signed with the committer’s verified signature. The key has been revoked.
    joachifm Joachim F.
    Copy the full SHA
    8d7f2c7 View commit details
15 changes: 9 additions & 6 deletions pkgs/applications/networking/irc/quassel/default.nix
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@
, static ? false # link statically

, stdenv, fetchFromGitHub, cmake, makeWrapper, dconf
, qtbase, qtscript
, mkDerivation, qtbase, qtscript
, phonon, libdbusmenu, qca-qt5

, withKDE ? true # enable KDE integration
@@ -20,6 +20,7 @@
}:

let
inherit (stdenv) lib;
buildClient = monolithic || client;
buildCore = monolithic || enableDaemon;
in
@@ -31,7 +32,7 @@ assert !buildClient -> !withKDE; # KDE is used by the client only
let
edf = flag: feature: [("-D" + feature + (if flag then "=ON" else "=OFF"))];

in with stdenv; mkDerivation rec {
in (if !buildClient then stdenv.mkDerivation else mkDerivation) rec {
name = "quassel${tag}-${version}";
version = "0.13.1";

@@ -67,13 +68,15 @@ in with stdenv; mkDerivation rec {
++ edf client "WANT_QTCLIENT"
++ edf withKDE "WITH_KDE";

preFixup =
dontWrapQtApps = true;

postFixup =
lib.optionalString enableDaemon ''
wrapProgram "$out/bin/quasselcore" --suffix PATH : "${qtbase.bin}/bin"
wrapProgram "$out/bin/quasselcore" --suffix PATH : "${qtbase.bin}/bin"
'' +
lib.optionalString buildClient ''
wrapProgram "$out/bin/quassel${lib.optionalString client "client"}" \
--prefix GIO_EXTRA_MODULES : "${dconf}/lib/gio/modules"
wrapQtApp "$out/bin/quassel${lib.optionalString client "client"}" \
--prefix GIO_EXTRA_MODULES : "${dconf}/lib/gio/modules"
'';

meta = with stdenv.lib; {
16 changes: 8 additions & 8 deletions pkgs/development/python-modules/premailer/default.nix
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
{ lib, buildPythonPackage, fetchPypi,
cssselect, cssutils, lxml, mock, nose, requests
cssselect, cssutils, lxml, mock, nose, requests, cachetools
}:

buildPythonPackage rec {
pname = "premailer";
version = "3.3.0";

meta = {
description = "Turns CSS blocks into style attributes ";
homepage = https://github.com/peterbe/premailer;
license = lib.licenses.bsd3;
};

src = fetchPypi {
inherit pname version;
sha256 = "93be4f197e9d2a87a8fe6b5b6a79b64070dbb523108dfaf2a415b4558fc78ec1";
};

buildInputs = [ mock nose ];
propagatedBuildInputs = [ cssselect cssutils lxml requests ];
propagatedBuildInputs = [ cachetools cssselect cssutils lxml requests ];

meta = {
description = "Turns CSS blocks into style attributes ";
homepage = https://github.com/peterbe/premailer;
license = lib.licenses.bsd3;
};
}
9 changes: 6 additions & 3 deletions pkgs/misc/drivers/epson-escpr2/default.nix
Original file line number Diff line number Diff line change
@@ -2,11 +2,14 @@

stdenv.mkDerivation rec {
pname = "epson-inkjet-printer-escpr2";
version = "1.0.29";
version = "1.1.1";

src = fetchurl {
url = "https://download3.ebz.epson.net/dsc/f/03/00/09/02/31/a332507b6398c6e2e007c05477dd6c3d5a8e50eb/${pname}-${version}-1lsb3.2.src.rpm";
sha256 = "064br52akpw5yrxb2wqw2klv4jrvyipa7w0rjj974xgyi781lqs5";
# To find new versions, visit http://download.ebz.epson.net/dsc/search/01/search/?OSC=LX
# and search for some printer like for instance "WF-7210" to get to the most recent version.
# NOTE: keep in mind that many parts of the URL change and not just version.
url = "https://download3.ebz.epson.net/dsc/f/03/00/09/72/04/c6d928e83e558c4ba1e7e8bcb5c1fe080b8095eb/${pname}-${version}-1lsb3.2.src.rpm";
sha256 = "02vdlhvinsx6vsjq172b2c1vrfzkg0w9j5lbsnjvj6yq3yqz5b5q";
};

patches = [ ./cups-filter-ppd-dirs.patch ];
9 changes: 3 additions & 6 deletions pkgs/tools/bluetooth/blueman/default.nix
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
{ config, stdenv, lib, fetchurl, intltool, pkgconfig, python3Packages, bluez, gtk3
, obex_data_server, xdg_utils, dnsmasq, dhcp, libappindicator, iproute
, gnome3, librsvg, wrapGAppsHook, gobject-introspection
, withNetworkManager ?
config.networking.networkmanager.enable or false, networkmanager
, withPulseAudio ? config.pulseaudio or stdenv.isLinux, libpulseaudio }:
, networkmanager, withPulseAudio ? config.pulseaudio or stdenv.isLinux, libpulseaudio }:

let
pythonPackages = python3Packages;
@@ -24,10 +22,9 @@ in stdenv.mkDerivation rec {
];

buildInputs = [ bluez gtk3 pythonPackages.python librsvg
gnome3.adwaita-icon-theme iproute libappindicator ]
gnome3.adwaita-icon-theme iproute libappindicator networkmanager ]
++ pythonPath
++ lib.optional withPulseAudio libpulseaudio
++ lib.optional withNetworkManager networkmanager;
++ lib.optional withPulseAudio libpulseaudio;

postPatch = lib.optionalString withPulseAudio ''
sed -i 's,CDLL(",CDLL("${libpulseaudio.out}/lib/,g' blueman/main/PulseAudioUtils.py