Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.gsd: 1.7.0 -> 1.9.1 #70064

Merged
merged 2 commits into from Oct 18, 2019
Merged

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 30, 2019

Motivation for this change

noticed a regression #69783

Actions:

  • froze gsd for python2
  • added tests for python3
  • bumped python3 version to 1.9.1

closes #69783

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[2 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70064
1 package were build:
python37Packages.gsd

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.gsd

@jonringer
Copy link
Contributor Author

bumped to 1.9.3

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build python3Packages.gsd pythonPackages.gsd

@jonringer
Copy link
Contributor Author

python38 broken due to pytest failure:

[1 built (1 failed), 0.0 MiB DL]
error: build of '/nix/store/sgnwpy2r915pvgnxansqqd9h6gmrcl38-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/70064
1 package failed to build:
python38Packages.gsd

1 package were build:
python37Packages.gsd

@jonringer jonringer merged commit 8f0aba0 into NixOS:master Oct 18, 2019
@jonringer jonringer deleted the bump-gsd branch October 18, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant