Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] libproxy: build with spidermonkey_60 #70065

Merged
merged 1 commit into from Oct 1, 2019
Merged

[19.09] libproxy: build with spidermonkey_60 #70065

merged 1 commit into from Oct 1, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

ZHF: #68361

This fixes a lot of stuff on i686-linux.

(note this patch isn't going to master because it's in gnome-3.34 branch c3204b3)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace merged commit 2ed7dfe into NixOS:release-19.09 Oct 1, 2019
@worldofpeace worldofpeace deleted the libproxy-19.09/fixbuild branch October 1, 2019 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@worldofpeace