zeek: 2.5.5 -> 3.0.0 #70046
Merged
zeek: 2.5.5 -> 3.0.0 #70046
+34
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
8.has: clean-up
8.has: package (new)
tobim
suggested changes
Oct 1, 2019
There was a problem hiding this comment.
Looks good! I did some light testing and the main executable worked as expected.
Add caf to buildInputs and "-DCAF_ROOT_DIR=${caf}" to cmakeFlags, otherwise the internal version will be used adding unnecessary compilation time.
unfortunately, I can't get it to built with the caf from nixpkgs
I think that is because caf got updated to 0.17 in the meantime, but zeek is still on 0.16..4
You can add to the list of maintainers.
|
Sorry I meant to say add me as maintainer. |
|
@tobim thanks for reviewing. I've addressed your comments |
|
no problem, I added you as maintainer |
tobim
approved these changes
Oct 2, 2019
|
I'll try to get around to write a function to build with packages from https://github.com/zeek/packages soon. |
ofborg
bot
added
the
11.by: package-maintainer
tobim
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
superseeds and closes #62695
feedback from @tobim in #62695:
unfortunately, I can't get it to built with the
caffrom nixpkgsdone
Not necessary, python2 users can still install python-ipaddress from pypi
Since I'm not familiar with the toPythonModule behavior, I’m going to tackle this later
done
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @tobim, I'd appreciate it you could review this PR