Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/cmt: Update error message when enabling cmt and plasma5 #70047

Closed
wants to merge 0 commits into from

Conversation

kcalvinalvin
Copy link
Member

@kcalvinalvin kcalvinalvin commented Sep 30, 2019

Updated error message for the assertion failure when enabling both cmt and plasma5. Fixes #69282

Motivation for this change

Clearer error message for the user

Things done

Updated the error message on assertion failure when enabling libinput in cmt.nix

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@@ -30,6 +30,7 @@ in {

config = mkIf cfg.enable {

services.xserver.libinput.enable = false; #plasma5.nix enables libinput by default which is incompatible with cmt.nix
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have this assertion below
!config.services.xserver.libinput.enable
which produces a message

cmt and libinput are incompatible, you cannot enable both (in services.xserver).

I think the actual issue is the module doesn't prompt the user to do any proactive change.
Can we change the message so it tells the users to disable services.xserver.libinput.enable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure that could also work.

@kcalvinalvin kcalvinalvin changed the title nixos/cmt: Fix incompatibility with plasma5 nixos/cmt: Update error message when enabling cmt and plasma5 Sep 30, 2019
@kcalvinalvin
Copy link
Member Author

Updated the PR to include clearer error message rather than disabling libinput in cmt.nix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling both module cmt.nix and plasma5.nix throws a failed assertion and build aborts
2 participants