Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xorg.*: set XFILESEARCHPATH for all xorg apps if applicable #70239

Closed
wants to merge 1 commit into from
Closed

xorg.*: set XFILESEARCHPATH for all xorg apps if applicable #70239

wants to merge 1 commit into from

Conversation

xzfc
Copy link
Contributor

@xzfc xzfc commented Oct 2, 2019

Motivation for this change

Make xorg apps look as intended. Most notable change: xmag color picker is usable now.

Commit description

Before this commit, only two apps had properly configured resource paths: bitmap and xcalc. This commit automates and generalizes it to the rest of xorg.* apps.

xorg.bitmap: bin/bitmap-color is no longer installed. If you would like bitmap to be viewable in color, please refer to man 1 bitmap, selection COLORS. The described method is also applied to some other affected apps.

Affected apps are:

  • bitmap
  • editres
  • oclock
  • viewres
  • xcalc
  • xclock
  • xconsole
  • xdm
  • xfd
  • xfontsel
  • xgc
  • xload
  • xmag
  • xmessage
  • xmore
  • xsm
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Mic92
Copy link
Member

Mic92 commented Oct 2, 2019

We should also backport this.

@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 2, 2019
@xzfc
Copy link
Contributor Author

xzfc commented Oct 2, 2019

Update: I forgot about bitmaps (e.g. button and menu icons). Now they should be displayed.

@xzfc xzfc changed the title xorg.*: set XAPPLRESDIR for all xorg apps if applicable xorg.*: set XFILESEARCHPATH for all xorg apps if applicable Oct 2, 2019
@xzfc
xorg.*: set XFILESEARCHPATH for all xorg apps if applicable
4a6b071 
Before this commit, only two apps had properly configured resource
paths: bitmap and xcalc.  This commit automates and generalizes it to
the rest of xorg.* apps.

xorg.bitmap: bin/bitmap-color is no longer installed.  If you would like
bitmap to be viewable in color, please refer to `man 1 bitmap`,
selection COLORS.  The described method is also applied to some other
affected apps.

Affected apps are:
- bitmap
- editres
- oclock
- viewres
- xcalc
- xclock
- xconsole
- xdm
- xfd
- xfontsel
- xgc
- xload
- xmag
- xmessage
- xmore
- xsm
@xzfc
Copy link
Contributor Author

xzfc commented Nov 3, 2019

Bump.
cc: @dtzWill (I'm not sure who is the maintainer of xorg.*, tho)

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review-may-2019/3032/96

@stale
Copy link

stale bot commented Jun 19, 2020

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 19, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@stale
Copy link

stale bot commented Jun 7, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 7, 2021
@Artturin
Copy link
Member

Artturin commented Jan 3, 2023

Replaced by #208900

@Artturin Artturin closed this Jan 3, 2023
@Artturin Artturin mentioned this pull request Jan 3, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@xzfc @Mic92 @nixos-discourse @Artturin @ryantm @worldofpeace