Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulnix: add missing setuptools dependency #70241

Merged
merged 1 commit into from Oct 2, 2019
Merged

vulnix: add missing setuptools dependency #70241

merged 1 commit into from Oct 2, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Oct 2, 2019

More #68314 related breakage.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh

@ofborg ofborg bot requested a review from ckauhaus October 2, 2019 11:03
@FRidh
Copy link
Member

FRidh commented Oct 2, 2019

Sure it was in vulnix itself? Could you show the trace?

@delroth
Copy link
Contributor Author

delroth commented Oct 2, 2019 •
edited 

$ vulnix
Traceback (most recent call last):
  File "/nix/store/380y6sbvk9a8f868s5m9hgx7hyfw629w-vulnix-1.8.2/bin/.vulnix-wrapped", line 7, in <module>
    from vulnix.main import main
  File "/nix/store/380y6sbvk9a8f868s5m9hgx7hyfw629w-vulnix-1.8.2/lib/python3.7/site-packages/vulnix/main.py", line 29, in <module>
    import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'

@delroth
Copy link
Contributor Author

delroth commented Oct 2, 2019

And https://github.com/flyingcircusio/vulnix/blob/master/src/vulnix/main.py#L29

@FRidh
Copy link
Member

FRidh commented Oct 2, 2019

Good, thanks!

@worldofpeace worldofpeace merged commit f8a5999 into NixOS:master Oct 2, 2019
@worldofpeace
Copy link
Contributor

backported in e0a544c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh approved these changes

@ckauhaus ckauhaus Awaiting requested review from ckauhaus

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@delroth @FRidh @worldofpeace