Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos module zfs: provide /etc/zfs/zpool.d #70240

Merged
merged 2 commits into from Oct 15, 2019
Merged

nixos module zfs: provide /etc/zfs/zpool.d #70240

merged 2 commits into from Oct 15, 2019

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Oct 2, 2019

The scripts for zpool iostat -c and zpool status -c are located in
/etc/zfs/zpool.d

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @adisbladis

@woffs
nixos module zfs: provide /etc/zfs/zpool.d
3065d00 
The scripts for zpool iostat -c and zpool status -c are located in
/etc/zfs/zpool.d
@woffs
Copy link
Contributor Author

woffs commented Oct 4, 2019

The scripts need coreutils (and more?) to work, I'll add another commit.

@Mic92 Mic92 changed the title nixos module zfs: provide /etc/zfs/zpool.d [WIP] nixos module zfs: provide /etc/zfs/zpool.d Oct 4, 2019
@woffs
Copy link
Contributor Author

woffs commented Oct 4, 2019

Now it works, but it adds dependency to sudo, smartmontools, and sysstat.

@woffs
Copy link
Contributor Author

woffs commented Oct 4, 2019

@GrahamcOfBorg test zfs

@woffs woffs changed the title [WIP] nixos module zfs: provide /etc/zfs/zpool.d nixos module zfs: provide /etc/zfs/zpool.d Oct 5, 2019
@Mic92 Mic92 merged commit faa7ce3 into NixOS:master Oct 15, 2019
@Mic92
Copy link
Member

Mic92 commented Oct 15, 2019

Looks like we should backport this one?

dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Dec 5, 2019
@Mic92 @dtzWill
Merge pull request NixOS#70240 from woffs/pr-etc-zpool.d
2064611 
nixos module zfs: provide /etc/zfs/zpool.d

(cherry picked from commit faa7ce3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@woffs @Mic92 @teto