I would dislike the idea of silently aliasing a package, maybe mark the other as broken and raise a warning if its referenced?

@Lassulus I marked COrebird as broken and added a comment in the expression referencing cawbird.
Is there a fancier way of raising a warning?

From my perspective this PR is ready, I just squashed all cawbird-related commits.

Sorry @FRidh, I don't need your review. The notification has been cause by an improper rebase.

@GrahamcOfBorg build cawbird

I think the sdImage commit is misplaced?

@Lassulus yes it is, but I don't know how to get rid of it.

I'm surprised it was added to the PR diff, as I just picked the existing commits in their previous order in my rebase -_-

Btw, this should also be backported to 19.09

git rebase -i HEAD~4
which will take you into a menu with all of your commits, then just replace pick with ... whatever delete/drop/remove command is, and save

@jonringer Fixed it. Still am surprised that just touching a commit without changing it with rebase sets it to "committed by me" :\

@GrahamcOfBorg eval

@jonringer Fixed it. Still am surprised that just touching a commit without changing it with rebase sets it to "committed by me" :\

if you change the base, you change the commit hash and so you are partly responsible

if you change the base, you change the commit hash and so you are partly responsible

But I did not change the base but only the most recent commits, leaving their predecessors completely unchanged (pick).

@jonringer all checks have passed

code LGTM, I would just like another opinion about deprecation mechanisms. @Ma27 whats your opinion?

In that case I guess that it's fine to use cawbird as upstream chose to use a different name.

Regarding corebird: as it seems to be/get EOLed I'd vote for dropping the package entirely and add a note in the release notes (we could also do corebird = throw "use cawbird instread"; for some time before dropping the attribute).

so we merge this now and @schmittlauch makes a new PR where he deletes corebird and throws the error message in all-packges.nix ?

@Lassulus As this PR already marks Corebird as broken, I better drop Corebird right away in this PR. Give me a minute…

@Lassulus done

huh github now shows the file as moved and shows the diff internally, a little bit confusing but I guess we can't do anything about it? I will try to rerun it and merge it afterwards

If we want to get this into 19.09, shall I add an entry to the release notes in the backport?

yes, add the notes to the stable manual in the backport

backport: #70287

backported in 8349643 b919677 5e0b687