Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transifex-client: Add missing setuptools dependency #70170

Merged
merged 1 commit into from Oct 1, 2019
Merged

transifex-client: Add missing setuptools dependency #70170

merged 1 commit into from Oct 1, 2019

Conversation

etu
Copy link
Contributor

@etu etu commented Oct 1, 2019

Motivation for this change

Fix runtime error:

Traceback (most recent call last):
  File "/nix/store/q9nlwh7ndxp7p6ivx1ac7k6w8vkhfgc4-transifex-client-0.13.6/bin/.tx-wrapped", line 7, in <module>
    from txclib.cmdline import main
  File "/nix/store/q9nlwh7ndxp7p6ivx1ac7k6w8vkhfgc4-transifex-client-0.13.6/lib/python3.7/site-packages/txclib/cmdline.py", line 7, in <module>
    from txclib import utils
  File "/nix/store/q9nlwh7ndxp7p6ivx1ac7k6w8vkhfgc4-transifex-client-0.13.6/lib/python3.7/site-packages/txclib/utils.py", line 37, in <module>
    from txclib.web import user_agent_identifier, certs_file
  File "/nix/store/q9nlwh7ndxp7p6ivx1ac7k6w8vkhfgc4-transifex-client-0.13.6/lib/python3.7/site-packages/txclib/web.py", line 5, in <module>
    from pkg_resources import resource_filename
ModuleNotFoundError: No module named 'pkg_resources'

This is an issue in 19.09 as well and needs to be backported.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@teto teto merged commit d1a8006 into NixOS:master Oct 1, 2019
@etu etu deleted the transifex-client-setuptools branch October 1, 2019 15:30
@etu etu mentioned this pull request Oct 1, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@etu @teto