Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blueman: no optional networkmanager #70149

Merged
merged 1 commit into from Oct 1, 2019
Merged

blueman: no optional networkmanager #70149

merged 1 commit into from Oct 1, 2019

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

blueman declares NetworkManager gi bindings
as a required runtime dependency 0

Fixes #69555

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 1, 2019
@ofborg ofborg bot requested a review from abbradar October 1, 2019 03:08
ck3d
ck3d approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@ck3d ck3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

successfully built blueman and started blueman-applet

@worldofpeace worldofpeace merged commit fb17018 into NixOS:master Oct 1, 2019
@worldofpeace worldofpeace deleted the blueman-fix branch October 1, 2019 05:28
@worldofpeace
Copy link
Contributor Author

backported in aaa1739

@ck3d ck3d mentioned this pull request Oct 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teto teto teto approved these changes

@ck3d ck3d ck3d approved these changes

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
3 participants
@worldofpeace @teto @ck3d