Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zig: 0.4.0 -> 0.5.0 #70147

Merged
merged 1 commit into from Oct 2, 2019
Merged

zig: 0.4.0 -> 0.5.0 #70147

merged 1 commit into from Oct 2, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Oct 1, 2019

Motivation for this change

Release Notes: https://ziglang.org/download/0.5.0/release-notes.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @andrewrk

@ofborg ofborg bot requested a review from andrewrk October 1, 2019 02:47
andrewrk
andrewrk approved these changes Oct 1, 2019
View reviewed changes
Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

The export HOME=$TMPDIR; is a nice solution. This is needed because part of the build is self-hosted, and it tries to use the freedesktop standards for the cache directory ($HOME/.local/share/zig). Setting HOME to TMPDIR during the build process is perfect. 👍

@marsam marsam merged commit 5067591 into NixOS:master Oct 2, 2019
@marsam marsam deleted the update-zig branch October 2, 2019 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewrk andrewrk andrewrk approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @andrewrk