Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages.phpcbf: 3.4.2 -> 3.5.0 #70034

Merged
merged 1 commit into from Sep 30, 2019
Merged

phpPackages.phpcbf: 3.4.2 -> 3.5.0 #70034

merged 1 commit into from Sep 30, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 29, 2019

Motivation for this change

Follow-up for #69941.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27 Ma27 requested a review from etu September 29, 2019 21:25
@ofborg ofborg bot requested a review from CMCDragonkai September 29, 2019 21:40
@etu etu merged commit 4eaf7d8 into NixOS:master Sep 30, 2019
@etu etu mentioned this pull request Sep 30, 2019
Merged
10 tasks
@Ma27 Ma27 deleted the bump-phpcbf branch September 30, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etu etu Awaiting requested review from etu

@CMCDragonkai CMCDragonkai Awaiting requested review from CMCDragonkai

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ma27 @etu