Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.xapian: disable smoketests #68711

Merged
merged 1 commit into from Sep 29, 2019
Merged

pythonPackages.xapian: disable smoketests #68711

merged 1 commit into from Sep 29, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 13, 2019 •
edited

Motivation for this change

#68361

they seem to all pass, then some weird logic causes it to sys.exit(1) after. Decided to just stick to the unittest suite.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

[3 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/68711
2 package were build:
python27Packages.xapian python37Packages.xapian

@risicle
Copy link
Contributor

risicle commented Sep 14, 2019

nix-review WFM macos 10.13.

@jonringer
Copy link
Contributor Author

@Ma27 needs merge and backport for ZHF

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 28, 2019
@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build pythonPackages.xapian python3Packages.xapian

@Ma27 Ma27 merged commit 99dd49f into NixOS:master Sep 29, 2019
@Ma27
Copy link
Member

Ma27 commented Sep 29, 2019

Thanks! Backported as 8873046.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Sep 29, 2019
@jonringer jonringer deleted the fix-xapian branch September 29, 2019 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @risicle @Ma27