Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk3-nocsd: init at 3.0.1 #70030

Closed
wants to merge 3 commits into from
Closed

gtk3-nocsd: init at 3.0.1 #70030

wants to merge 3 commits into from

Conversation

Abbie5
Copy link

@Abbie5 Abbie5 commented Sep 29, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Contributor

I'm pretty sure there are other ways to disable CSD to enable SSD in gtk than this.
Not to mention, I'm not really fond of having something in the official nixpkgs repository that's purely a "hack". Also a hack that hasn't seen contributions in 3 or so years.
I do see other distro's have packaged it

but it seems to one of those things that might already be abandoned, and thusly if I were to merge this it would add to the abondonware we already have in nixpkgs.

@Abbie5
Copy link
Author

Abbie5 commented Sep 30, 2019

If there are other ways to disable CSD in GTK+ 3 I haven't heard of them.

There is an active fork of gtk3-nocsd with a few fixes, so I can package that instead if that would be better.

@worldofpeace
Copy link
Contributor

@peanutbutter144 Yep, active forks are pretty much the only way I think this could be acceptable.

Use ZaWertun's actively maintained fork
@Abbie5 Abbie5 changed the title gtk3-nocsd: init at 3 gtk3-nocsd: init at 3.0.1 Oct 2, 2019
@Abbie5
Copy link
Author

Abbie5 commented Oct 8, 2019

@worldofpeace are these changes acceptable to merge?

@Abbie5 Abbie5 closed this Oct 18, 2019
@worldofpeace
Copy link
Contributor

Did you close this due to my non-response @peanutbutter144? My apologies if that caused you to not want to pursue this. nixpkgs is kinda busy, and my notifications are rather hard to parse.

Do you still want to maintain this?

@Abbie5
Copy link
Author

Abbie5 commented Oct 18, 2019

I closed it because 1. I don't use the library any more and 2. I don't want to maintain it.

Sorry for closing without explanation.

@worldofpeace
Copy link
Contributor

Thanks for explaining @peanutbutter144 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants