Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtk3-nocsd: init at 3 #70028

Closed
wants to merge 5 commits into from
Closed

gtk3-nocsd: init at 3 #70028

wants to merge 5 commits into from

Conversation

Abbie5
Copy link

@Abbie5 Abbie5 commented Sep 29, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Abbie5 Abbie5 requested a review from FRidh as a code owner September 29, 2019 18:37
@Abbie5 Abbie5 closed this Sep 29, 2019
@Abbie5 Abbie5 deleted the gtk3-nocsd branch September 29, 2019 18:42
@Abbie5
Copy link
Author

Abbie5 commented Sep 29, 2019

there were some leftover commits, new pull request at #70030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants