Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/plasma5: disable libinput from being enabled by default #70031

Closed
wants to merge 1 commit into from

Conversation

kcalvinalvin
Copy link
Member

@kcalvinalvin kcalvinalvin commented Sep 29, 2019

Resolves #69282

Motivation for this change

Enabling both plasma5.nix and cmt.nix will throw an assertion error since plasma5.nix enables libinput.nix by default. This resolves it by removing it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @worldofpeace @adisbladis @ttuegel

fixes cmt.nix throwing an assertion error
@kcalvinalvin
Copy link
Member Author

Just saw #68233

Synaptics may be depreciated but cmt is up to date and are great drivers for Chromebooks. In my opinion, I think it's worth giving the users an option.

@worldofpeace
Copy link
Contributor

You do have the option @kcalvinalvin, you can change the value of the option (it uses mkDefault).

services.xserver.libinput.enable = false;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling both module cmt.nix and plasma5.nix throws a failed assertion and build aborts
2 participants