Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpPackages.psalm: init at 3.5.3 #70069

Merged
merged 1 commit into from
Oct 1, 2019
Merged

phpPackages.psalm: init at 3.5.3 #70069

merged 1 commit into from
Oct 1, 2019
+26 −0

Conversation

shyim
Copy link
Member

@shyim shyim commented Sep 30, 2019

Motivation for this change

It's a well known alternative to already packaged phpstan.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

Sorry, something went wrong.

@shyim
phpPackages.psalm: init at 3.5.3

Verified

This commit was signed with the committer’s verified signature. The key has expired.
Mic92 Jörg Thalheim
GPG key ID: B3F5D81B0C6967C4
Expired
Verified
Learn about vigilant mode
9cd1e90
@shyim shyim changed the title Add psalm phpPackages.psalm: init at 3.5.3 Sep 30, 2019
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Sep 30, 2019
@etu
Copy link
Contributor

etu commented Oct 1, 2019

@GrahamcOfBorg build phpPackages.psalm

@etu etu merged commit 6b11080 into NixOS:master Oct 1, 2019
@shyim shyim deleted the add-psalm branch October 1, 2019 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shyim @etu