Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/borgbackup: add option to allow removable devices #70070

Merged
merged 1 commit into from Oct 14, 2019
Merged

nixos/borgbackup: add option to allow removable devices #70070

merged 1 commit into from Oct 14, 2019

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Sep 30, 2019 •
edited

Motivation for this change

When having backup jobs that persist to a removable device like an
external HDD, the directory shouldn't be created by an activation script
as this might confuse auto-mounting tools such as udiskie(8).

In this case the job will simply fail, with the former approach
udiskie ran into some issues as the path /run/media/ma27/backup was
already there and owned by root.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27 Ma27 requested a review from dotlambda September 30, 2019 16:23
@Ma27
nixos/borgbackup: add option to allow removable devices
2dfc675 
When having backup jobs that persist to a removable device like an
external HDD, the directory shouldn't be created by an activation script
as this might confuse auto-mounting tools such as udiskie(8).

In this case the job will simply fail, with the former approach
udiskie ran into some issues as the path `/run/media/ma27/backup` was
already there and owned by root.
@Ma27 Ma27 force-pushed the borgbackup-removable-devices branch from 9670db8 to 2dfc675 Compare October 14, 2019 15:29
WilliButz
WilliButz approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@WilliButz WilliButz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good to me 👍

Even though I will currently not do it myself, I would really like to see the activation script in a pre-start hook of the actual backup service instead.

@WilliButz WilliButz merged commit 104b93e into NixOS:master Oct 14, 2019
@Ma27 Ma27 deleted the borgbackup-removable-devices branch October 14, 2019 16:06
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 15, 2019
@WilliButz @dtzWill
Merge pull request NixOS#70070 from Ma27/borgbackup-removable-devices
417eb65 
nixos/borgbackup: add option to allow removable devices

(cherry picked from commit 104b93e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@WilliButz WilliButz WilliButz approved these changes

@dotlambda dotlambda Awaiting requested review from dotlambda

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @bjornfor @WilliButz