Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.cufflinks: 0.15 -> 0.16 #70220

Merged
merged 2 commits into from Oct 7, 2019
Merged

pythonPackages.cufflinks: 0.15 -> 0.16 #70220

merged 2 commits into from Oct 7, 2019

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Oct 2, 2019 •
edited

Motivation for this change

noticed it was broken on master with:

$ nix-build -A pythonPackages.cufflinks
...
ImportError:
The plotly.plotly module is deprecated,
please install the chart-studio package and use the
chart_studio.plotly module instead.

so I did the following:

  • Added the chart-studio package
  • Added patch which gave support to the new plotly version
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

closure includes numpy, expected to be large:

$ nix path-info -Sh ./result
/nix/store/r48nwnlgvv45fy6f0qar7lklflc59hfi-python2.7-cufflinks-0.16     564.8M

[3 built, 2 copied (37.1 MiB), 7.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70220
4 package were build:
python27Packages.chart-studio python27Packages.cufflinks python37Packages.chart-studio python37Packages.cufflinks

@jonringer jonringer requested a review from FRidh as a code owner October 2, 2019 03:44
@jonringer jonringer added the 9.needs: port to stable A PR needs a backport to the stable release. label Oct 2, 2019
@ofborg ofborg bot requested a review from globin October 2, 2019 04:00
@jonringer jonringer mentioned this pull request Oct 2, 2019
Closed
10 tasks
@jonringer
Copy link
Contributor Author

fixes two builds, tired of seeing this fail in other reviews, merging.

[3 built, 2 copied (73.2 MiB), 14.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/70220
4 package were build:
python27Packages.chart-studio python27Packages.cufflinks python37Packages.chart-studio python37Packages.cufflinks

@jonringer jonringer merged commit 7d297e4 into NixOS:master Oct 7, 2019
@jonringer jonringer deleted the fix-cufflinks branch October 7, 2019 08:57
@jonringer
Copy link
Contributor Author

backported as dbc6baa f364b99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jonringer