Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haskellPackages.proteaaudio: link with the AudioToolbox framework on Darwin #70152

Merged
merged 1 commit into from Oct 7, 2019
Merged

haskellPackages.proteaaudio: link with the AudioToolbox framework on Darwin #70152

merged 1 commit into from Oct 7, 2019

Conversation

mujx
Copy link
Contributor

@mujx mujx commented Oct 1, 2019

Motivation for this change

The build is currently failing on Darwin due to missing headers. see #70151

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

…Darwin

The build is currently failing on Darwin due to missing headers. see #70151
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mujx Thanks for this as well!

@peti I've confirmed this builds on MacOSX as well as Linux now. This should be ready to be merged.

@peti peti merged commit f6f043f into NixOS:master Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants