Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go_1_12: 1.12.9 -> 1.12.10 #70153

Merged
merged 1 commit into from Oct 2, 2019
Merged

go_1_12: 1.12.9 -> 1.12.10 #70153

merged 1 commit into from Oct 2, 2019

Conversation

d-goldin
Copy link
Contributor

@d-goldin d-goldin commented Oct 1, 2019

Motivation for this change

GO 1.12.10 has been released 5 days ago, so
bumping it in the hope that it also fixes some
flakey GC tests.

Also see #69359 and #68361

Please give it a run for i686 and aarch64 on ofBorg, I don't have permissions for this yet and locally i686 is not reproducible for me.

cc @globin @WilliButz because of previous conversations about this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @Mic92

@d-goldin
Copy link
Contributor Author

d-goldin commented Oct 1, 2019

I just checked and neither 1.13 nor 1.12.10 contains the commit that was tried in the previous WIP PR. But I guess might be still worth checking. In any case, if it doesnt fix this issue, version bump is still worthwhile.

@ofborg ofborg bot requested review from cstrahan, velovix and Mic92 October 1, 2019 06:39
@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build go_1_12

@jonringer
Copy link
Contributor

Seeing as the current go_1_12 is still building (at least for me) would it make more sense for this to land in staging as opposed to master (causes 500+ rebuilds)

@worldofpeace
Copy link
Contributor

@jonringer I was going to suggest this 👍

@d-goldin Can you rebase onto staging?

@d-goldin
Copy link
Contributor Author

d-goldin commented Oct 2, 2019

@worldofpeace: Yeah, will do in a sec.

Wrt building - yeah, it builds fine most of the time, but especially with a bunch of tests something seems to trigger this test in particular. I spent a bit more time on trying to reproduce more reliably, but still can't, so there was a bit of hope that through random luck it might stop happening ;)

I'm fine with it either way.

@d-goldin
go_1_12: 1.12.9 -> 1.12.10
aa46781 
GO 1.12.10 has been released 5 days ago, so
bumping it in the hope that it also fixes some
flakey GC tests.

Also see NixOS#69359
@d-goldin d-goldin changed the base branch from master to staging October 2, 2019 04:10
@jonringer
Copy link
Contributor

@GrahamcOfBorg eval

@Mic92
Copy link
Member

Mic92 commented Oct 2, 2019

@GrahamcOfBorg build go

@worldofpeace worldofpeace merged commit 2519be4 into NixOS:staging Oct 2, 2019
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Oct 2, 2019
@worldofpeace @dtzWill
Merge pull request NixOS#70153 from d-goldin/go_1.12.10
0cda317 
go_1_12: 1.12.9 -> 1.12.10

(cherry picked from commit 2519be4)
@d-goldin d-goldin deleted the go_1.12.10 branch October 2, 2019 14:32
@d-goldin d-goldin mentioned this pull request Oct 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

@cstrahan cstrahan Awaiting requested review from cstrahan

@velovix velovix Awaiting requested review from velovix

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@d-goldin @worldofpeace @jonringer @Mic92