Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[staging]librsvg: 2.44.15 -> 2.46.0 #70063

Closed
wants to merge 1 commit into from
Closed

[staging]librsvg: 2.44.15 -> 2.46.0 #70063

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Sep 30, 2019 •
edited

Motivation for this change

noticed it was broken when reviewing a few other packages. Bumping it seems to fix the build.

should help with #70056 #69837

this causes a lot of rebuilds, so opening against staging

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @FRidh (curates staging often)

@worldofpeace
Copy link
Contributor

We actually already did this in gnome-3.34 branch 2b488eb. Didn't realize this was broken on master, guess rust was updated?

I can merge that to staging now if it's needed. cc @hedning @jtojnar

@jonringer
Copy link
Contributor Author

correct #69534

jtojnar
jtojnar requested changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to remove gtk3 like in 2b488eb.

@hedning
Copy link
Contributor

hedning commented Sep 30, 2019

Any problems with sending it to master, as it's broken there so needs to be rebuild anyway? (especially since broken librsvg means broken channels).

@hedning
librsvg: 2.44.14 → 2.46.0
572d7a7 
rsvg-view was removed so GTK is not needed anymore
@worldofpeace
Copy link
Contributor

@hedning Rust was updated in master, so yes we can merge that commit there 👍

@jonringer
Copy link
Contributor Author

i just cherry picked the commit

@worldofpeace
Copy link
Contributor

Merged one way or another to master in 02585db 😄

@jonringer
Copy link
Contributor Author

well, that's one way to do it. lol

@jonringer jonringer deleted the bump-librsvg-staging branch September 30, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar requested changes

@hedning hedning Awaiting requested review from hedning

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonringer @worldofpeace @hedning @jtojnar