Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kube3d: build as GoModule instead of GoPackage #70062

Merged
merged 1 commit into from Sep 30, 2019
Merged

kube3d: build as GoModule instead of GoPackage #70062

merged 1 commit into from Sep 30, 2019

Conversation

jlesquembre
Copy link
Member

Motivation for this change

kube3d: build as GoModule instead of GoPackage

Also adds build flags version and k3sVersion. Previously it was using
the default, dev and latest

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @kuznero

@jlesquembre
kube3d: build as GoModule instead of GoPackage
7f14d44 
Also adds build flags version and k3sVersion. Previously it was using
the default, dev and latest
@ofborg ofborg bot requested review from kalbasit and kuznero September 30, 2019 15:09
@kalbasit
Copy link
Member

@GrahamcOfBorg build kube3d

@kalbasit kalbasit merged commit b2c12ab into NixOS:master Sep 30, 2019
@jlesquembre jlesquembre deleted the kube3d branch October 2, 2019 07:38
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 27, 2020
@jlesquembre @dtzWill
kube3d: build as GoModule instead of GoPackage (NixOS#70062)
ac320e0 
Also adds build flags version and k3sVersion. Previously it was using the default, dev and latest

(cherry picked from commit b2c12ab)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

@kuznero kuznero Awaiting requested review from kuznero

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jlesquembre @kalbasit