Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librsvg: 2.44.15 -> 2.46.0 #70061

Closed
wants to merge 1 commit into from
Closed

librsvg: 2.44.15 -> 2.46.0 #70061

wants to merge 1 commit into from

Conversation

jonringer
Copy link
Contributor

Motivation for this change

noticed it was broken when reviewing a few other packages. Bumping it seems to fix the build.

should help with #70056 #69837

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@jonringer
Copy link
Contributor Author

closing due to rebuild count being 100+

@jonringer jonringer closed this Sep 30, 2019
@jonringer jonringer deleted the bump-librsvg branch September 30, 2019 14:58
@jtojnar
Copy link
Contributor

jtojnar commented Sep 30, 2019

Note you can change base branch using the Edit button in the top right.

@jonringer
Copy link
Contributor Author

I was aware, but because one was based on top of master, and the other staging, I'm not aware of a good way to do that atomically. Didn't want to spam 20+ people with all the changes between the the branches

@hedning
Copy link
Contributor

hedning commented Sep 30, 2019

Yeah, as far as I'm aware you'll have to something like move your branch on top of the merge-base of the new and old target branch, force push, change target branch, and then rebase and force push again if you want a newer parent. 😆

@jonringer
Copy link
Contributor Author

I guess there's a window in which ofborg eval's something, if i was quick enough, i could avoid the spam after I force-push

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonringer @jtojnar @hedning